]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
jbd2: Fix possible overflow in jbd2_log_space_left()
authorJan Kara <jack@suse.cz>
Tue, 5 Nov 2019 16:44:07 +0000 (17:44 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 11 Feb 2020 20:03:27 +0000 (20:03 +0000)
commita27a720075fff5529e3674786aa2ede9ec3b18a9
tree78e6032fc310f38889777d49eb22dd19649bf84d
parentded55327ebba737a602eb1fe2f653ce41f5156da
jbd2: Fix possible overflow in jbd2_log_space_left()

commit add3efdd78b8a0478ce423bb9d4df6bd95e8b335 upstream.

When number of free space in the journal is very low, the arithmetic in
jbd2_log_space_left() could underflow resulting in very high number of
free blocks and thus triggering assertion failure in transaction commit
code complaining there's not enough space in the journal:

J_ASSERT(journal->j_free > 1);

Properly check for the low number of free blocks.

Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20191105164437.32602-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
include/linux/jbd2.h