]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: reset fs_root to NULL on error in open_ctree
authorJosef Bacik <josef@toxicpanda.com>
Thu, 13 Feb 2020 15:47:28 +0000 (10:47 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 16:23:40 +0000 (17:23 +0100)
commita2c971c017132e09ea7cb333f31577d07edb0a55
treebba7a663fa2d3c8889393bbdac1c4db0309f5ad4
parent2fdba5d3b2cbb911d86b68eea7ba45014d88f0e0
btrfs: reset fs_root to NULL on error in open_ctree

commit 315bf8ef914f31d51d084af950703aa1e09a728c upstream.

While running my error injection script I hit a panic when we tried to
clean up the fs_root when freeing the fs_root.  This is because
fs_info->fs_root == PTR_ERR(-EIO), which isn't great.  Fix this by
setting fs_info->fs_root = NULL; if we fail to read the root.

CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/disk-io.c