]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Revert "qemu: propagate bridge MTU into qemu "host_mtu" option"
authorLaine Stump <laine@laine.org>
Thu, 18 May 2017 18:16:27 +0000 (14:16 -0400)
committerCole Robinson <crobinso@redhat.com>
Tue, 30 May 2017 22:04:35 +0000 (18:04 -0400)
commita2f5e87dceb1725c16cd4df17a4b7381ecf65901
tree90812a96ab136d5620599ff8963fe8ebed39bde5
parent4a7d3495525cfb29a16a7e9cf69f63185772ca4e
Revert "qemu: propagate bridge MTU into qemu "host_mtu" option"

This reverts commit 2841e675.

It turns out that adding the host_mtu field to the PCI capabilities in
the guest bumps the length of PCI capabilities beyond the 32 byte
boundary, so the virtio-net device gets 64 bytes of ioport space
instead of 32, which offsets the address of all the other following
devices. Migration doesn't work very well when the location and length
of PCI capabilities of devices is changed between source and
destination.

This means that we need to make sure that the absence/presence of
host_mtu on the qemu commandline always matches between source and
destination, which means that we need to make setting of host_mtu an
opt-in thing (it can't happen automatically when the bridge being used
has a non-default MTU, which is what commit 2841e675 implemented).

I do want to re-implement this feature with an <mtu auto='on'/>
setting, but probably won't backport that to any stable branches, so
I'm first reverting the original commit, and that revert can be pushed
to the few releases that have been made since the original (3.1.0 -
3.3.0)

Resolves: https://bugzilla.redhat.com/1449346
(cherry picked from commit 77780a29edace958a1f931d3281b962be4f5290e)
src/qemu/qemu_command.c
src/qemu/qemu_command.h
src/qemu/qemu_hotplug.c
src/qemu/qemu_interface.c
src/qemu/qemu_interface.h