]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: aquantia: return 'err' if set MPI_DEINIT state fails
authorYueHaibing <yuehaibing@huawei.com>
Sat, 24 Nov 2018 10:16:41 +0000 (18:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 19:02:12 +0000 (20:02 +0100)
commita35e4e7ca77a9f1dca8b57333721903ba7d5feec
treebc69bf5d01c9051ede440e01f199ad2b19c6231a
parent5950802fc30199b8892acb201d2a82614a23137e
net: aquantia: return 'err' if set MPI_DEINIT state fails

[ Upstream commit 4e3c7c00bba0636b97eb23d582c20b0f5d95ce20 ]

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:260:7:
 warning: variable 'err' set but not used [-Wunused-but-set-variable]

'err' should be returned while set MPI_DEINIT state fails
in hw_atl_utils_soft_reset.

Fixes: cce96d1883da ("net: aquantia: Regression on reset with 1.x firmware")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c