]> git.ipfire.org Git - thirdparty/gcc.git/commit
rs6000: Fix C++14 vs. C++17 ABI bug on powerpc64le [PR94707]
authorJakub Jelinek <jakub@redhat.com>
Thu, 23 Apr 2020 07:59:57 +0000 (09:59 +0200)
committerJakub Jelinek <jakub@redhat.com>
Thu, 23 Apr 2020 07:59:57 +0000 (09:59 +0200)
commita39ed81b8a0b46320a7c6ece3f7ad4c3f8519609
treeaba814967463c0754dc4a2574277ff2ea015ab61
parente2a71816b4949225498bec37e947293aa7f5841b
rs6000: Fix C++14 vs. C++17 ABI bug on powerpc64le [PR94707]

As mentioned in the PR and on IRC, the recently added struct-layout-1.exp
new tests FAIL on powerpc64le-linux (among other targets).
FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_tst.o-cp_compat_y_tst.o execute
in particular.  The problem is that the presence or absence of the C++17
artificial empty base fields, which have non-zero TYPE_SIZE, but zero
DECL_SIZE, change the ABI decisions, if it is present (-std=c++17), the type
might not be considered homogeneous, while if it is absent (-std=c++14), it
can be.

The following patch fixes that and emits a -Wpsabi inform; perhaps more
often than it could, because the fact that rs6000_discover_homogeneous_aggregate
returns true when it didn't in in GCC 7/8/9 with -std=c++17 doesn't still
mean it will make a different ABI decision, but the warning triggered only
on the test I've changed (the struct-layout-1.exp tests use -w -Wno-psabi
already).

2020-04-23  Jakub Jelinek  <jakub@redhat.com>

PR target/94707
* config/rs6000/rs6000-call.c (rs6000_aggregate_candidate): Add
cxx17_empty_base_seen argument.  Pass it to recursive calls.
Ignore cxx17_empty_base_field_p fields after setting
*cxx17_empty_base_seen to true.
(rs6000_discover_homogeneous_aggregate): Adjust
rs6000_aggregate_candidate caller.  With -Wpsabi, diagnose homogeneous
aggregates with C++17 empty base fields.

* g++.dg/tree-ssa/pr27830.C: Use -Wpsabi -w for -std=c++17 and higher.
gcc/ChangeLog
gcc/config/rs6000/rs6000-call.c
gcc/testsuite/ChangeLog
gcc/testsuite/g++.dg/tree-ssa/pr27830.C