]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Avoid sending push request after receving push reply
authorArne Schwabe <arne@rfc2549.org>
Sat, 25 Jul 2020 23:48:03 +0000 (01:48 +0200)
committerGert Doering <gert@greenie.muc.de>
Sun, 26 Jul 2020 16:52:57 +0000 (18:52 +0200)
commita3b21a76b87fedf045c409481f55c34486d8cd27
treee0ec5676c2355e9baf76e7d3372a1b68b41ac39b
parent7cadbe24b6e5b583b4e763cd7a3b30d540b1c7a0
Avoid sending push request after receving push reply

The introduction of IV_PROTO_REQUEST_PUSH (c290df55) sometimes causes the
server to reply before we setup the push timer. The push reply will then
clear a timer that has not been setup yet. We then start sending push
request after we have gone through the whole initialisation already.

This patch also clears the connestion_established timer that sets up the
push request timer. This lead to the

  management_set_state(management,  OPENVPN_STATE_GET_CONFIG, ...)

function not being called. But to display "waiting for configuration..." or
sending a "getting config state" after "initialisation" does not make sense
anyway.

Also add the IV_PROTO_REQUEST_PUSH feature as new feature in Changes.rst

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20200725234803.22058-2-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20589.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Changes.rst
src/openvpn/forward.c
src/openvpn/push.c