]> git.ipfire.org Git - thirdparty/gcc.git/commit
Remove unreachable gcc_unreachable () at the end of functions
authorRichard Biener <rguenther@suse.de>
Wed, 24 Nov 2021 14:57:03 +0000 (15:57 +0100)
committerRichard Biener <rguenther@suse.de>
Mon, 29 Nov 2021 10:18:35 +0000 (11:18 +0100)
commita3b31fe3692894e80de16b4059a89a309e409687
treec6c945f5d3d893cb2ac000b12f07854eae1c53ce
parent16507dea753527d073f1cfb7200c6612a7fa44aa
Remove unreachable gcc_unreachable () at the end of functions

It seems to be a style to place gcc_unreachable () after a
switch that handles all cases with every case returning.
Those are unreachable (well, yes!), so they will be elided
at CFG construction time and the middle-end will place
another __builtin_unreachable "after" them to note the
path doesn't lead to a return when the function is not declared
void.

So IMHO those explicit gcc_unreachable () serve no purpose,
if they could be replaced by a comment.  But since all cases
cover switches not handling a case or not returning will
likely cause some diagnostic to be emitted which is better
than running into an ICE only at runtime.

2021-11-24  Richard Biener  <rguenther@suse.de>

* tree.h (reverse_storage_order_for_component_p): Remove
spurious gcc_unreachable.
* cfganal.c (dfs_find_deadend): Likewise.
* fold-const-call.c (fold_const_logb): Likewise.
(fold_const_significand): Likewise.
* gimple-ssa-store-merging.c (lhs_valid_for_store_merging_p):
Likewise.

gcc/c-family/
* c-format.c (check_format_string): Remove spurious
gcc_unreachable.
gcc/c-family/c-format.c
gcc/cfganal.c
gcc/fold-const-call.c
gcc/gimple-ssa-store-merging.c
gcc/tree.h