]> git.ipfire.org Git - thirdparty/qemu.git/commit
acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot()
authorIgor Mammedov <imammedo@redhat.com>
Thu, 26 Mar 2020 13:56:24 +0000 (09:56 -0400)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 29 Mar 2020 13:52:13 +0000 (09:52 -0400)
commita3ec4bb7e55956dc633e2248cf76f27d3b9c9c9d
tree732c8f4a4afffd59e8cf0042fcb5bf6abbbaaba0
parent0d930b870a87fe12648e5674288a2bcb6ae4a144
acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot()

Coverity spots subj in following guest triggered code path
  pci_write(, data = 0) -> acpi_pcihp_eject_slot(,slots = 0)
     uinst32_t slot = ctz32(slots)
     ...
     ... = ~(1U << slot)
where 'slot' value is 32 in case 'slots' bitmap is empty.
'slots' is a bitmap and empty one shouldn't  do anything
so return early doing nothing if resulted slot value is
not valid (i.e. not in 0-31 range)

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200326135624.32464-1-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/acpi/pcihp.c