]> git.ipfire.org Git - thirdparty/qemu.git/commit
qga/vss-win32: fix warning for clang++-15
authorPierrick Bouvier <pierrick.bouvier@linaro.org>
Tue, 21 Feb 2023 15:30:05 +0000 (16:30 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 10 Apr 2023 08:19:08 +0000 (11:19 +0300)
commita3f531cee66b12041098f7a809c2a7d6ecb6ad7d
tree915582fe60f07c3bdb54c382517277db071bfb82
parent5d4218f0b22812b37662f29a5c33619823f948e0
qga/vss-win32: fix warning for clang++-15

Reported when compiling with clang-windows-arm64.

../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
    if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here
    return hr;
           ^~

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure")
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Kostiantyn Kostiuk <kostyanf14@live.com>
(cherry picked from commit 0fcd574b025fccdf14d5140687cafe2bc30b634f)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
qga/vss-win32/install.cpp