]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/smc: Fix sock leak when release after smc_shutdown()
authorTony Lu <tonylu@linux.alibaba.com>
Thu, 14 Apr 2022 07:51:03 +0000 (15:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Apr 2022 11:53:49 +0000 (13:53 +0200)
commita499cb5f3ef9f976eac96c02adbcc505764e2b91
treec69ff7ad2c330f4c81eb525d916abfaa0b13edf1
parent60592f16a456d239df9060968dd9cb561d0a6fb0
net/smc: Fix sock leak when release after smc_shutdown()

[ Upstream commit 1a74e99323746353bba11562a2f2d0aa8102f402 ]

Since commit e5d5aadcf3cd ("net/smc: fix sk_refcnt underflow on linkdown
and fallback"), for a fallback connection, __smc_release() does not call
sock_put() if its state is already SMC_CLOSED.

When calling smc_shutdown() after falling back, its state is set to
SMC_CLOSED but does not call sock_put(), so this patch calls it.

Reported-and-tested-by: syzbot+6e29a053eb165bd50de5@syzkaller.appspotmail.com
Fixes: e5d5aadcf3cd ("net/smc: fix sk_refcnt underflow on linkdown and fallback")
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/smc/af_smc.c