]> git.ipfire.org Git - thirdparty/zlib-ng.git/commit
Fix regex for visibility attribute tests
authorlawadr <3211473+lawadr@users.noreply.github.com>
Fri, 17 Mar 2023 16:35:13 +0000 (16:35 +0000)
committerHans Kristian Rosbach <hk-github@circlestorm.org>
Mon, 27 Mar 2023 18:05:40 +0000 (20:05 +0200)
commita4e1f1c981c04d36c3cf4e9eed93f10280f97579
tree853d5abcc93661ed06b20fa8c0d716c3ff6a3095
parent1521bee18ea17d7df97ae9effe39ff9833565522
Fix regex for visibility attribute tests

The previous regex of `not supported` was very specific to a particular
compiler (Clang 3.4+). As Clang isn't the only compiler that throws a
warning (but otherwise succeeds) when a visibility isn't supported, make
the regex more generic to hit all such cases.

Testing on Compiler Explorer shows that looking for the string
`visibility` has a better hit rate. `attribute` is perhaps more
dangerously generic, and `hidden`/`internal` doesn't always show up in
warning messages when the visibility attribute itself isn't available.
CMakeLists.txt