]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/mips: Simplify and fix update_pagemask
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 28 Mar 2025 17:55:26 +0000 (12:55 -0500)
committerMichael Tokarev <mjt@tls.msk.ru>
Sat, 5 Apr 2025 13:51:46 +0000 (16:51 +0300)
commita527d31074f74c4225bd57b14d5c07299de0984e
tree042717b9124b3878bfbba22df689ea7825628494
parentc3fdfe81ab3f2a4bebad905d6065d0ed1a7841cc
target/mips: Simplify and fix update_pagemask

When update_pagemask was split from helper_mtc0_pagemask,
we failed to actually write to the new parameter but continue
to write to env->CP0_PageMask.  Thus the use within
page_table_walk_refill modifies cpu state and not the local
variable as expected.

Simplify by renaming to compute_pagemask and returning the
value directly.  No need for either env or pointer return.

Fixes: 074cfcb4dae ("target/mips: Implement hardware page table walker for MIPS32")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250328175526.368121-4-richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Cc: qemu-stable@nongnu.org
(cherry picked from commit 256ba7715b109c080c0c77a3923df9e69736ba17)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/mips/tcg/sysemu/cp0_helper.c
target/mips/tcg/sysemu/tlb_helper.c
target/mips/tcg/tcg-internal.h