]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_repair: set args.geo in longform_dir2_entry_check_data
authorEric Sandeen <sandeen@sandeen.net>
Wed, 2 Sep 2015 22:40:50 +0000 (08:40 +1000)
committerDave Chinner <david@fromorbit.com>
Wed, 2 Sep 2015 22:40:50 +0000 (08:40 +1000)
commita5459506e64df9a8e943dd855f3dc81203e31946
tree7f628304b09a027844efb9498b85fc31afd72d2a
parentfe0591e7ad48fc9e459ef62052be19a3bed61d5a
xfs_repair: set args.geo in longform_dir2_entry_check_data

Here's another one where we miss setting da_args->geo:

longform_dir2_entry_check_data
        struct xfs_da_args      da = {
                .dp = ip,
// .geo is unset
        };
...
libxfs_dir2_data_make_free(&da ...)
xfs_dir2_data_make_free
endptr = (char *)hdr + args->geo->blksize;
BOOM

Addresses-Coverity-Id: 1298008
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
repair/phase6.c