]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Detect integer overflow in array_set_slice().
authorNathan Bossart <nathan@postgresql.org>
Wed, 24 Jul 2024 02:59:02 +0000 (21:59 -0500)
committerNathan Bossart <nathan@postgresql.org>
Wed, 24 Jul 2024 02:59:02 +0000 (21:59 -0500)
commita57d168653900903e8b1b4fe91d62de2c2f2693d
tree6603b1af1ffd8d91e8d20ddf4522330c8e5377b4
parent74e15462848de9cc9c302a8f6e12c3b04288b6a1
Detect integer overflow in array_set_slice().

When provided an empty initial array, array_set_slice() fails to
check for overflow when computing the new array's dimensions.
While such overflows are ordinarily caught by ArrayGetNItems(),
commands with the following form are accepted:

INSERT INTO t (i[-2147483648:2147483647]) VALUES ('{}');

To fix, perform the hazardous computations using overflow-detecting
arithmetic routines.  As with commit 18b585155a, the added test
cases generate errors that include a platform-dependent value, so
we again use psql's VERBOSITY parameter to suppress printing the
message text.

Reported-by: Alexander Lakhin
Author: Joseph Koshakow
Reviewed-by: Jian He
Discussion: https://postgr.es/m/31ad2cd1-db94-bdb3-f91a-65ffdb4bef95%40gmail.com
Backpatch-through: 12
src/backend/utils/adt/arrayfuncs.c
src/test/regress/expected/arrays.out
src/test/regress/sql/arrays.sql