]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove PointerIsValid()
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 24 Sep 2025 13:14:06 +0000 (15:14 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 24 Sep 2025 13:17:20 +0000 (15:17 +0200)
commita5b35fcedb542587e7d8b8fcd21a2e0995b82d2f
treee8fc20fe42313590549cc80ec3f16ca8ee39b526
parent0fba25eb720a6a20b8f3c9597dd0417a0d20fc94
Remove PointerIsValid()

This doesn't provide any value over the standard style of checking the
pointer directly or comparing against NULL.

Also remove related:
- AllocPointerIsValid() [unused]
- IndexScanIsValid() [had one user]
- HeapScanIsValid() [unused]
- InvalidRelation [unused]

Leaving HeapTupleIsValid(), ItemIdIsValid(), PortalIsValid(),
RelationIsValid for now, to reduce code churn.

Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/ad50ab6b-6f74-4603-b099-1cd6382fb13d%40eisentraut.org
Discussion: https://www.postgresql.org/message-id/CA+hUKG+NFKnr=K4oybwDvT35dW=VAjAAfiuLxp+5JeZSOV3nBg@mail.gmail.com
Discussion: https://www.postgresql.org/message-id/bccf2803-5252-47c2-9ff0-340502d5bd1c@iki.fi
37 files changed:
src/backend/access/common/reloptions.c
src/backend/access/common/tupdesc.c
src/backend/access/index/indexam.c
src/backend/access/transam/xact.c
src/backend/catalog/index.c
src/backend/catalog/objectaddress.c
src/backend/catalog/pg_proc.c
src/backend/catalog/pg_type.c
src/backend/commands/foreigncmds.c
src/backend/commands/tablecmds.c
src/backend/nodes/outfuncs.c
src/backend/postmaster/autovacuum.c
src/backend/storage/ipc/sinvaladt.c
src/backend/storage/large_object/inv_api.c
src/backend/utils/adt/acl.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/datum.c
src/backend/utils/adt/xml.c
src/backend/utils/cache/catcache.c
src/backend/utils/cache/relcache.c
src/backend/utils/cache/syscache.c
src/backend/utils/error/assert.c
src/backend/utils/mmgr/aset.c
src/backend/utils/mmgr/bump.c
src/backend/utils/mmgr/generation.c
src/backend/utils/mmgr/portalmem.c
src/backend/utils/mmgr/slab.c
src/include/access/genam.h
src/include/access/heapam.h
src/include/access/htup.h
src/include/access/itup.h
src/include/c.h
src/include/lib/radixtree.h
src/include/storage/itemid.h
src/include/storage/itemptr.h
src/include/utils/portal.h
src/include/utils/rel.h