]> git.ipfire.org Git - thirdparty/qemu.git/commit
s390x/ccw: make sure all ccw devices are properly reset
authorCornelia Huck <cohuck@redhat.com>
Mon, 7 May 2018 13:27:57 +0000 (15:27 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 11 Jul 2018 16:48:18 +0000 (11:48 -0500)
commita5c8fbbeac13adf2508da743e0564dd2a49c4e8a
treed5ed1cff53e4f9a3c3da0391798c0db8b814a1ec
parentc9bb0778713397f10352cfecb38da09e5806bede
s390x/ccw: make sure all ccw devices are properly reset

Thomas reported that the subchannel for a  3270 device that ended up
in a broken state (status pending even though not enabled) did not
get out of that state even after a reboot (which involves a subsytem
reset). The reason for this is that the 3270 device did not define
a reset handler.

Let's fix this by introducing a base reset handler (set up for all
ccw devices) that resets the subchannel and have virtio-ccw call
its virtio-specific reset procedure in addition to that.

CC: qemu-stable@nongnu.org
Reported-by: Thomas Huth <thuth@redhat.com>
Suggested-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
(cherry picked from commit 838fb84f83c84f00d15b1bede5e080b495644458)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/s390x/ccw-device.c
hw/s390x/virtio-ccw.c
hw/s390x/virtio-ccw.h