]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: hda/realtek: Fix bass speaker DAC assignment on Asus Zephyrus G14
authorTakashi Iwai <tiwai@suse.de>
Fri, 27 Nov 2020 14:11:04 +0000 (15:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Dec 2020 12:22:05 +0000 (13:22 +0100)
commita5e4d94b74f93b66252798ca08f6fdb0a4240268
tree387c77434d4e7ea3eaa5e3a96711c324fc3d812c
parent9920472eaa7c652c7abcad4911fa83b6ae5a4955
ALSA: hda/realtek: Fix bass speaker DAC assignment on Asus Zephyrus G14

commit c84bfedce60192c08455ee2d25dd13d19274a266 upstream.

ASUS Zephyrus G14 has two speaker pins, and the auto-parser tries to
assign an individual DAC to each pin as much as possible.
Unfortunately the third DAC has no volume control unlike the two DACs,
and this resulted in the inconsistent speaker volumes.

As a workaround, wire both speaker pins to the same DAC by modifying
the existing quirk (ALC289_FIXUP_ASUS_GA401) applied to this device.
Since this quirk entry is chained by another, we need to avoid
applying the DAC assignment change for it.  Luckily, there is another
quirk entry (ALC289_FIXUP_ASUS_GA502) doing the very same thing, so we
can chain to the GA502 quirk instead.

Note that this patch uses a new flag of the generic parser,
obey_preferred_dacs, for enforcing the DACs.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210359
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20201127141104.11041-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/patch_realtek.c