]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
projects / thirdparty / kernel / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ee7255a) | patch
pptp: fix stack info leak in pptp_getname()
authorMathias Krause <minipli@googlemail.com>
Wed, 19 Nov 2014 17:05:26 +0000 (18:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Nov 2014 03:43:47 +0000 (22:43 -0500)
commita5f6fc28d6e6cc379c6839f21820e62262419584
treef251bb2b01c2465cd791c4db2d5ef2dfe9ef83b6tree | snapshot
parentee7255ada313a6db99be47ce174b0bfb8295a041commit | diff
pptp: fix stack info leak in pptp_getname()

pptp_getname() only partially initializes the stack variable sa,
particularly only fills the pptp part of the sa_addr union. The code
thereby discloses 16 bytes of kernel stack memory via getsockname().

Fix this by memset(0)'ing the union before.

Cc: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp/pptp.c diff | blob | blame | history
A mirror of Linus' kernel repository