]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
amd-xgbe: Use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Tue, 26 Aug 2025 14:21:59 +0000 (22:21 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Aug 2025 01:06:46 +0000 (18:06 -0700)
commita6bac1822931bc3c862c07d535ab4192582c023c
tree8c225f058f12c487f3dacc74f7252a164cb52060
parent330355191a2d9a59137455b774b9a66dd6d068d4
amd-xgbe: Use int type to store negative error codes

Use int instead of unsigned int for the 'ret' variable to store return
values from functions that either return zero on success or negative error
codes on failure.  Storing negative error codes in an unsigned int causes
no runtime issues, but it's ugly as pants,  Change 'ret' from unsigned int
to int type - this change has no runtime impact.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250826142159.525059-1-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
drivers/net/ethernet/amd/xgbe/xgbe-i2c.c
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c