]> git.ipfire.org Git - thirdparty/coreutils.git/commit
maint: avoid signed overflow warning with -O3
authorPádraig Brady <P@draigBrady.com>
Mon, 1 Dec 2014 23:04:36 +0000 (23:04 +0000)
committerPádraig Brady <P@draigBrady.com>
Tue, 2 Dec 2014 01:20:39 +0000 (01:20 +0000)
commita6d979299717e3769debfa5d295cb2934683077b
treec2f56be45168d188b109fd2b7af07fa2e5bbc8de
parentdc1c0523a61932fb0c26a795b7e7391eadf2171a
maint: avoid signed overflow warning with -O3

Prompted by the implicit -O3 added by american-fuzzy-lop,
seen with GCC 4.9.2 on x86_64.

  src/pr.c: In function 'print_files.part.5':
  src/pr.c:1781:6: error: assuming signed overflow does not occur
  when simplifying conditional to constant [-Werror=strict-overflow]
     if (cols_ready_to_print () == 0)

This happens because cols_ready_to_print() is inlined
thus reducing the comparison to the N variable in print_page().
Now this can't overflow due to the protection when parsing the
specified column, but use an unsigned type to avoid the
apparent signed overflow.

* src/pr.c (cols_ready_to_print): Increment an unsigned type to
avoid the subsequent signed overflow warning.
src/pr.c