]> git.ipfire.org Git - thirdparty/qemu.git/commit
qapi: expose rtc-reset-reinjection command unconditionally
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 22 May 2025 19:05:28 +0000 (12:05 -0700)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2025 16:26:23 +0000 (18:26 +0200)
commita78a91feeea66270badd87c65a7236e90baa5984
tree5ee337278be603245074f33add50978674e4fb47
parent80db93b2b88f9b3ed8927ae7ac74ca30e643a83e
qapi: expose rtc-reset-reinjection command unconditionally

This removes the TARGET_I386 condition from the rtc-reset-reinjection
command. This requires providing a QMP command stub for non-i386 target.
This in turn requires moving the command out of misc-target.json, since
that will trigger symbol poisoning errors when built from target
independent code.

Rather than putting the command into misc.json, it is proposed to create
misc-$TARGET.json files to hold commands whose impl is conceptually
only applicable to a single target. This gives an obvious docs hint to
consumers that the command is only useful in relation a specific target,
while misc.json is for commands applicable to 2 or more targets.

The current impl of qmp_rtc_reset_reinject() is a no-op if the i386
RTC is disabled in Kconfig, or if the running machine type lack any
RTC device.

The stub impl for non-i386 targets retains this no-op behaviour.
However, it is now reporting an Error mentioning this command is not
available for current target.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-ID: <20250522190542.588267-2-pierrick.bouvier@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
hw/i386/monitor.c
qapi/meson.build
qapi/misc-i386.json [new file with mode: 0644]
qapi/misc-target.json
qapi/qapi-schema.json
stubs/meson.build
stubs/monitor-i386-rtc.c [new file with mode: 0644]