]> git.ipfire.org Git - thirdparty/qemu.git/commit
smbios: Fix buffer overrun when using path= option
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Sun, 23 Mar 2025 21:35:54 +0000 (22:35 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 8 Apr 2025 18:45:13 +0000 (20:45 +0200)
commita7a05f5f6a4085afbede315e749b1c67e78c966b
treed47a182f5030450dadf308f90b50e8e3b3b0ff97
parentdfaecc04c46d298e9ee81bd0ca96d8754f1c27ed
smbios: Fix buffer overrun when using path= option

We have to make sure the array of bytes read from the path= file
is null-terminated, otherwise we run into a buffer overrun later on.

Fixes: bb99f4772f54017490e3356ecbb3df25c5d4537f ("hw/smbios: support loading OEM strings values from a file")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2879

Signed-off-by: Daan De Meyer <daan.j.demeyer@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Valentin David <valentin.david@canonical.com>
Message-ID: <20250323213622.2581013-1-daan.j.demeyer@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/smbios/smbios.c