]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/misc/mmio_interface: Return after error_setg() to avoid crash
authorThomas Huth <thuth@redhat.com>
Mon, 14 Aug 2017 06:10:29 +0000 (08:10 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 14 Aug 2017 10:06:54 +0000 (13:06 +0300)
commita808c0865b720e22ca2929ec3d362d4610fbad51
tree7a9c6edd33e062b376e2374e88aa75081ffb720b
parenta3e08c2dbd7db9b86e174f5e50c6aa7a59a2b21d
hw/misc/mmio_interface: Return after error_setg() to avoid crash

QEMU currently abort()s if the user tries to specify the mmio_interface
device without parameters:

x86_64-softmmu/qemu-system-x86_64 -nographic -device mmio_interface
qemu-system-x86_64: /home/thuth/devel/qemu/util/error.c:57: error_setv:
 Assertion `*errp == ((void *)0)' failed.
Aborted (core dumped)

This happens because the realize function is trying to set the errp
twice in this case. After setting an error, the realize function
should immediately return instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/misc/mmio_interface.c