]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: musb: host: fix potential NULL pointer dereference
authorBin Liu <b-liu@ti.com>
Mon, 30 Apr 2018 16:20:53 +0000 (11:20 -0500)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:40 +0000 (21:36 -0400)
commita82b0b8ad435f93b287832e32947d994a18d6796
tree834070af541e5a0dee8f1d923cf275da3a9d66b6
parenta58e27f02868d084de8a8a56ff410a56b945c483
usb: musb: host: fix potential NULL pointer dereference

[ Upstream commit 2b63f1329df2cd814c1f8353fae4853ace6521d1 ]

musb_start_urb() doesn't check the pass-in parameter if it is NULL.  But
in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
returned from first_qh(), which could be NULL.

So wrap the musb_start_urb() call here with a if condition check to
avoid the potential NULL pointer dereference.

Fixes: f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")
Cc: stable@vger.kernel.org # v3.7+
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/usb/musb/musb_host.c