]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: ethoc: enable NAPI before poll may be scheduled
authorMax Filippov <jcmvbkbc@gmail.com>
Tue, 6 Jun 2017 01:31:16 +0000 (18:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2017 13:05:52 +0000 (15:05 +0200)
commita83564d128637c99d454cc1918b69ca84b9ce688
treeb9a6ded2f703dfbc9d950902dbe714b411a5697e
parenta97f807363d4f3c8c849a0e12064305d5bb5a6dc
net: ethoc: enable NAPI before poll may be scheduled

[ Upstream commit d220b942a4b6a0640aee78841608f4aa5e8e185e ]

ethoc_reset enables device interrupts, ethoc_interrupt may schedule a
NAPI poll before NAPI is enabled in the ethoc_open, which results in
device being unable to send or receive anything until it's closed and
reopened. In case the device is flooded with ingress packets it may be
unable to recover at all.
Move napi_enable above ethoc_reset in the ethoc_open to fix that.

Fixes: a1702857724f ("net: Add support for the OpenCores 10/100 Mbps Ethernet MAC.")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/ethoc.c