]> git.ipfire.org Git - thirdparty/linux.git/commit
NFSD: Document lack of f_pos_lock in nfsd_readdir()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 20 Nov 2023 01:17:11 +0000 (20:17 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 7 Jan 2024 22:54:25 +0000 (17:54 -0500)
commita853ed552545e116cf9b197b8c3c5cec80077f1e
tree23d81bb342f0171bfe0c67b24cd8703ff522775d
parentd0ab8b649ba7636d181605e31bf3e42b0784bc67
NFSD: Document lack of f_pos_lock in nfsd_readdir()

Al Viro notes that normal system calls hold f_pos_lock when calling
->iterate_shared and ->llseek; however nfsd_readdir() does not take
that mutex when calling these methods.

It should be safe however because the struct file acquired by
nfsd_readdir() is not visible to other threads.

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/vfs.c