]> git.ipfire.org Git - thirdparty/linux.git/commit
ASoC: soc-card: soc-card-test: Fix some error handling in init()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 12 Apr 2024 12:07:01 +0000 (15:07 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 14 Apr 2024 07:54:39 +0000 (16:54 +0900)
commita8cad4a4e431e250edc05242a8ca1be6e4b33749
treea1768bf3bf26833aabba5fdcd195587f89553a84
parent4be7bc275253c0f35c8f6362af1ee5d91d5d83e9
ASoC: soc-card: soc-card-test: Fix some error handling in init()

There are two issues here:
1) The get_device() needs a matching put_device() on error paths.
2) The "if (!ret)" was supposed to be "if (ret)".

I re-arranged the code a bit to do the allocation before the
get_device().

Fixes: ef7784e41db7 ("ASoC: soc-card: Add KUnit test case for snd_soc_card_get_kcontrol")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/450dd21a-b24b-48ba-9aa4-c02e4617852f@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-card-test.c