]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/riscv: Fix tb->flags FS status
authorShihPo Hung <shihpo.hung@sifive.com>
Wed, 15 Jan 2020 06:17:31 +0000 (22:17 -0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 22 Jun 2020 17:08:54 +0000 (12:08 -0500)
commita918ea2ec342cf51bb4a069f6d97f9e704cb048b
tree42847b271b68e4dc4090af9581dac8d09ece6587
parentc1cad76dcd7630333738393625399b8ca0b71e43
target/riscv: Fix tb->flags FS status

It was found that running libquantum on riscv-linux qemu produced an
incorrect result. After investigation, FP registers are not saved
during context switch due to incorrect mstatus.FS.

In current implementation tb->flags merges all non-disabled state to
dirty. This means the code in mark_fs_dirty in translate.c that
handles initial and clean states is unreachable.

This patch fixes it and is successfully tested with:
  libquantum

Thanks to Richard for pointing out the actual bug.

v3: remove the redundant condition
v2: root cause FS problem

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: ShihPo Hung <shihpo.hung@sifive.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
(cherry picked from commit 613fa160e19abe8e1fe44423fcfa8ec73d3d48e5)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
target/riscv/cpu.h