]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
9p locks: fix glock.client_id leak in do_lock
authorDominique Martinet <dominique.martinet@cea.fr>
Fri, 7 Sep 2018 16:18:43 +0000 (01:18 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2018 08:21:58 +0000 (09:21 +0100)
commita9dbfcffbfba56b40afbafb63efdce633e560f4a
tree6b357f470f922075f0e8403ff919ac8f6e873c0c
parentb710256edba8c0e92a9fff05aa67f6c47910379a
9p locks: fix glock.client_id leak in do_lock

[ Upstream commit b4dc44b3cac9e8327e0655f530ed0c46f2e6214c ]

the 9p client code overwrites our glock.client_id pointing to a static
buffer by an allocated string holding the network provided value which
we do not care about; free and reset the value as appropriate.

This is almost identical to the leak in v9fs_file_getlock() fixed by
Al Viro in commit ce85dd58ad5a6 ("9p: we are leaking glock.client_id
in v9fs_file_getlock()"), which was returned as an error by a coverity
false positive -- while we are here attempt to make the code slightly
more robust to future change of the net/9p/client code and hopefully
more clear to coverity that there is no problem.

Link: http://lkml.kernel.org/r/1536339057-21974-5-git-send-email-asmadeus@codewreck.org
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/9p/vfs_file.c