]> git.ipfire.org Git - people/ms/linux.git/commit
ALSA: opti9xx: Fix conflicting driver object name
authorTakashi Iwai <tiwai@suse.de>
Tue, 27 Aug 2013 10:03:01 +0000 (12:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Sep 2013 04:58:14 +0000 (21:58 -0700)
commitaa5189165d9897c84b43d762618ee8924c5f9c9e
tree6f2a73fffd00914fe07e96ec47f54f92c42e5a4d
parente446ef9608a07af0cf07aa887ddf37224fd345d8
ALSA: opti9xx: Fix conflicting driver object name

commit fb615499f0ad28ed74201c1cdfddf9e64e205424 upstream.

The recent commit to delay the release of kobject triggered NULL
dereferences of opti9xx drivers.  The cause is that all
snd-opti92x-ad1848, snd-opti92x-cs4231 and snd-opti93x drivers
register the PnP card driver with the very same name, and also
snd-opti92x-ad1848 and -cs4231 drivers register the ISA driver with
the same name, too.  When these drivers are built in, quick
"register-release-and-re-register" actions occur, and this results in
Oops because of the same name is assigned to the kobject.

The fix is simply to assign individual names.  As a bonus, by using
KBUILD_MODNAME, the patch reduces more lines than it adds.

The fix is based on the suggestion by Russell King.

Reported-and-tested-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/isa/opti9xx/opti92x-ad1848.c