]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio-scsi: define dummy handle_output for vhost-scsi vqs
authorMing Lei <ming.lei@canonical.com>
Thu, 19 Jun 2014 08:12:00 +0000 (16:12 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 5 Aug 2014 18:58:37 +0000 (13:58 -0500)
commitaa69eda237ccac63c355d8520ea11175900ace78
tree61d9317af45736229c31ad8fae04dc9c8a161918
parent8dedaf0f7037baa6c5b0b06a6eccfb120dcead44
virtio-scsi: define dummy handle_output for vhost-scsi vqs

vhost userspace needn't to handle vq's notification from guest,
so define dummy handle_output callback for all vqs of vhost-scsi.

In some corner cases(such as when handling vq's reset from VM), virtio-pci
still trys to handle pending virtio-scsi events, then object check failure
inside virtio_scsi_handle_event() for vhost-scsi can be triggered.

The issue can be reproduced by 'rmmod virtio-scsi', 'system sleep' or reboot
inside VM.

Cc: qemu-stable@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 91d670fbf9945ca4ecbd123affb36889e7fe8a5d)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/scsi/vhost-scsi.c
hw/scsi/virtio-scsi.c
include/hw/virtio/virtio-scsi.h