]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
efi: Fix build error due to enum collision between efi.h and ima.h
authorAnders Roxell <anders.roxell@linaro.org>
Fri, 15 Feb 2019 16:55:51 +0000 (17:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2019 20:34:36 +0000 (22:34 +0200)
commitaa6c9fcac011bf67a43bb36bccb54aebd69fff83
treef1e8ce6d0058569223972f313401b8281601a716
parent55d7152d37dccfa9add45df82fd45c373e032f46
efi: Fix build error due to enum collision between efi.h and ima.h

[ Upstream commit 5c418dc789a3898717ebf2caa5716ba91a7150b2 ]

The following commit:

  a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h")

introduced a build error when both IMA and EFI are enabled:

    In file included from ../security/integrity/ima/ima_fs.c:30:
    ../security/integrity/ima/ima.h:176:7: error: redeclaration of enumerator "NONE"

What happens is that both headers (ima.h and efi.h) defines the same
'NONE' constant, and it broke when they started getting included from
the same file:

Rework to prefix the EFI enum with 'EFI_*'.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20190215165551.12220-2-ard.biesheuvel@linaro.org
[ Cleaned up the changelog a bit. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/platform/efi/quirks.c
drivers/firmware/efi/runtime-wrappers.c
include/linux/efi.h