]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix assertion failure when running pgbench -s.
authorFujii Masao <fujii@postgresql.org>
Thu, 7 Nov 2019 07:31:36 +0000 (16:31 +0900)
committerFujii Masao <fujii@postgresql.org>
Thu, 7 Nov 2019 07:33:23 +0000 (16:33 +0900)
commitaa7cd6a8e7414d4d52c44ebe246567e3c44d9df9
treee00056386f342dce94e7f0eea4a6e2f988eed177
parent16b43e091c779cd8c34cdaeeacbe402bfb99dd5c
Fix assertion failure when running pgbench -s.

If there is the WAL page that the continuation WAL record just fits within
(i.e., the continuation record ends just at the end of the page) and
the LSN in such page is specified with -s option, previously pg_waldump
caused an assertion failure. The cause of this assertion failure was that
XLogFindNextRecord() that pg_waldump -s calls mistakenly handled
such special WAL page.

This commit changes XLogFindNextRecord() so that it can handle
such WAL page correctly.

Back-patch to all supported versions.

Author: Andrey Lepikhov
Reviewed-by: Fujii Masao, Michael Paquier
Discussion: https://postgr.es/m/99303554-5dd5-06e6-f943-b3005ccd6edd@postgrespro.ru
src/backend/access/transam/xlogreader.c