]> git.ipfire.org Git - people/ms/gcc.git/commit
c-family: Honor -Wno-init-self for cv-qual vars [PR102633]
authorMarek Polacek <polacek@redhat.com>
Tue, 26 Jul 2022 17:55:58 +0000 (13:55 -0400)
committerJakub Jelinek <jakub@redhat.com>
Fri, 10 Feb 2023 15:19:36 +0000 (16:19 +0100)
commitaabebf76e9d9a805ea5b443d4ee4f49f13155d87
tree8a441078792829fd0785ebbdcea12a865ae93542
parentc153fb6a5bda225fcfb34e17994a31b65616a6db
c-family: Honor -Wno-init-self for cv-qual vars [PR102633]

Since r11-5188-g32934a4f45a721, we drop qualifiers during l-to-r
conversion by creating a NOP_EXPR.  For e.g.

  const int i = i;

that means that the DECL_INITIAL is '(int) i' and not 'i' anymore.
Consequently, we don't suppress_warning here:

711     case DECL_EXPR:
715       if (VAR_P (DECL_EXPR_DECL (*expr_p))
716           && !DECL_EXTERNAL (DECL_EXPR_DECL (*expr_p))
717           && !TREE_STATIC (DECL_EXPR_DECL (*expr_p))
718           && (DECL_INITIAL (DECL_EXPR_DECL (*expr_p)) == DECL_EXPR_DECL (*expr_p))
719           && !warn_init_self)
720         suppress_warning (DECL_EXPR_DECL (*expr_p), OPT_Winit_self);

because of the check on line 718 -- (int) i is not i.  So -Wno-init-self
doesn't disable the warning as it's supposed to.

The following patch fixes it by moving the suppress_warning call from
c_gimplify_expr to the front ends, at points where we haven't created
the NOP_EXPR yet.

PR middle-end/102633

gcc/c-family/ChangeLog:

* c-gimplify.cc (c_gimplify_expr) <case DECL_EXPR>: Don't call
suppress_warning here.

gcc/c/ChangeLog:

* c-parser.cc (c_parser_initializer): Add new tree parameter.  Use it.
Call suppress_warning.
(c_parser_declaration_or_fndef): Pass d down to c_parser_initializer.
(c_parser_omp_declare_reduction): Pass omp_priv down to
c_parser_initializer.

gcc/cp/ChangeLog:

* decl.cc (cp_finish_decl): Call suppress_warning.

gcc/testsuite/ChangeLog:

* c-c++-common/Winit-self1.c: New test.
* c-c++-common/Winit-self2.c: New test.

(cherry picked from commit 04ce2400b35225302e0d6883bb0817378180f5d7)
gcc/c-family/c-gimplify.cc
gcc/c/c-parser.cc
gcc/cp/decl.cc
gcc/testsuite/c-c++-common/Winit-self1.c [new file with mode: 0644]
gcc/testsuite/c-c++-common/Winit-self2.c [new file with mode: 0644]