]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix 'compress migrate' for 2.2 clients.
authorGert Doering <gert@greenie.muc.de>
Fri, 2 Apr 2021 13:45:29 +0000 (15:45 +0200)
committerGert Doering <gert@greenie.muc.de>
Fri, 2 Apr 2021 14:47:09 +0000 (16:47 +0200)
commitaba8776e6721030565b7b4ba3f88ac537ddcc5e0
tree59a3d9553a27594c94fc84bc7940ba7deaaf9e87
parent8fa8a17528c001abc7d5f45e9c2ffa3ed2f6af43
Fix 'compress migrate' for 2.2 clients.

Commit 8fa8a17528c001a introduces "compress migrate" to move old clients
that have "compress" or "comp-lzo" in their config towards a connection
without compression.  This is done by looking at incoming OCC strings
to see if the client has compression enabled, and at incoming IV_
strings to see whether it can do "compress stub-v2" or needs to be sent
"comp-lzo no".

That check fails for 2.2 clients that do not send *any* peer-info by
default, so the server will not push back any "disable compression"
command.  It works if the client connects with "--push-peer-info".

Fix: turn around the order of checks, treat "no peer_info" the same
as "peer_info does not contain IV_COMP_STUBv2".

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20210402134529.27866-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21974.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/multi.c