]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/mlx5e: Fix eswitch mode block underflow on IPsec acquire SA
authorPrathamesh Deshpande <prathameshdeshpande7@gmail.com>
Sun, 10 May 2026 22:59:00 +0000 (23:59 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 May 2026 22:19:29 +0000 (15:19 -0700)
commitabe003b33223ff33552f291644bf35d9c2f992fb
treeb649e71ca8e253d4202c7d2752eb0b4244730a64
parent9a8e01c50093e6fc6569aa8353f856f1b6097189
net/mlx5e: Fix eswitch mode block underflow on IPsec acquire SA

mlx5e_xfrm_add_state() handles acquire-flow temporary SAs by allocating
software state and skipping hardware offload setup.

That path jumps to the common success label before taking the eswitch mode
block. After tunnel-mode validation was moved earlier, the common success
label unconditionally calls mlx5_eswitch_unblock_mode(). For acquire SAs,
this decrements esw->offloads.num_block_mode without a matching increment.

Return directly after installing the acquire SA offload handle, so only the
paths that successfully called mlx5_eswitch_block_mode() call the matching
unblock.

Fixes: 22239eb258bc ("net/mlx5e: Prevent tunnel reformat when tunnel mode not allowed")
Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260510225903.13184-1-prathameshdeshpande7@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c