]> git.ipfire.org Git - thirdparty/linux.git/commit
r8169: don't take RTNL lock in rtl_task()
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 16 Oct 2024 20:05:57 +0000 (22:05 +0200)
committerAndrew Lunn <andrew@lunn.ch>
Sun, 20 Oct 2024 15:20:42 +0000 (10:20 -0500)
commitac48430368c1a4f4e6c2fa92243b4b93fd25bee4
treed3b5305ecf6635efd863b307ac465d633a3e8454
parentd3296a9d0bc2576a8e3dee7925d6f47e1f225fc2
r8169: don't take RTNL lock in rtl_task()

There's not really a benefit here in taking the RTNL lock. The task
handler does exception handling only, so we're in trouble anyway when
we come here, and there's no need to protect against e.g. a parallel
ethtool call.
A benefit of removing the RTNL lock here is that we now can
synchronously cancel the workqueue from a context holding the RTNL mutex.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
drivers/net/ethernet/realtek/r8169_main.c