]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
keys, dns: Fix size check of V1 server-list header
authorDavid Howells <dhowells@redhat.com>
Wed, 10 Jan 2024 21:11:40 +0000 (21:11 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 10 Jan 2024 21:20:08 +0000 (13:20 -0800)
commitacc657692aed438e9931438f8c923b2b107aebf9
tree6dadc3efea4d586961f75770fa9f6003d6adff6c
parent0cb552aa97843f24549ce808883494138471c16b
keys, dns: Fix size check of V1 server-list header

Fix the size check added to dns_resolver_preparse() for the V1 server-list
header so that it doesn't give EINVAL if the size supplied is the same as
the size of the header struct (which should be valid).

This can be tested with:

        echo -n -e '\0\0\01\xff\0\0' | keyctl padd dns_resolver desc @p

which will give "add_key: Invalid argument" without this fix.

Fixes: 1997b3cb4217 ("keys, dns: Fix missing size check of V1 server-list header")
Reported-by: Pengfei Xu <pengfei.xu@intel.com>
Link: https://lore.kernel.org/r/ZZ4fyY4r3rqgZL+4@xpf.sh.intel.com/
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/dns_resolver/dns_key.c