]> git.ipfire.org Git - thirdparty/libvirt.git/commit
vnc: add support for listen type 'socket'
authorPavel Hrdina <phrdina@redhat.com>
Wed, 8 Jun 2016 13:18:25 +0000 (15:18 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Thu, 9 Jun 2016 12:42:48 +0000 (14:42 +0200)
commitacc83afe333bfadd3f7f79091d38ca3d7da1eeb2
tree4aa7f189e9ed5366356047792f10d94cce62f560
parentb6465e1aa49397367a9cd0f27110b9c2280a7385
vnc: add support for listen type 'socket'

VNC graphics already supports sockets but only via 'socket' attribute.
This patch coverts that attribute into listen type 'socket'.

For backward compatibility we need to handle listen type 'socket' and 'socket'
attribute properly to support old XMLs and new XMLs.  If both are provided they
have to match, if only one of them is provided we need to be able to parse that
configuration too.

To not break migration back to old libvirt if the socket is provided by user we
need to generate migratable XML without the listen element and use only 'socket'
attribute.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
27 files changed:
docs/formatdomain.html.in
src/conf/domain_conf.c
src/conf/domain_conf.h
src/qemu/qemu_command.c
src/qemu/qemu_domain.c
src/qemu/qemu_parse_command.c
src/qemu/qemu_process.c
src/security/virt-aa-helper.c
src/vz/vz_sdk.c
tests/genericxml2xmlindata/generic-graphics-vnc-socket-attr-listen-address.xml [new file with mode: 0644]
tests/genericxml2xmlindata/generic-graphics-vnc-socket-attr-listen-socket-mismatch.xml [new file with mode: 0644]
tests/genericxml2xmlindata/generic-graphics-vnc-socket-attr-listen-socket.xml [new file with mode: 0644]
tests/genericxml2xmloutdata/generic-graphics-vnc-socket-attr-listen-address.xml [new file with mode: 0644]
tests/genericxml2xmloutdata/generic-graphics-vnc-socket-attr-listen-socket.xml [new file with mode: 0644]
tests/genericxml2xmloutdata/generic-graphics-vnc-socket-listen.xml
tests/genericxml2xmloutdata/generic-graphics-vnc-socket.xml
tests/genericxml2xmltest.c
tests/qemuargv2xmldata/qemuargv2xml-graphics-vnc-socket.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-auto-socket.xml [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.args
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml
tests/qemuxml2argvtest.c
tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-auto-socket.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-remove-generated-socket-active.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-graphics-vnc-socket.xml [new file with mode: 0644]
tests/qemuxml2xmltest.c