]> git.ipfire.org Git - thirdparty/grub.git/commit
net/net: Fix incorrect condition for calling grub_net_tcp_retransmit()
authorGlenn Washburn <development@efficientek.com>
Thu, 12 May 2022 02:44:01 +0000 (21:44 -0500)
committerDaniel Kiper <daniel.kiper@oracle.com>
Tue, 24 May 2022 12:37:24 +0000 (14:37 +0200)
commitad019a107a17460620374b1fc29b78884153fdb8
treea99369f350fd1aa509b964f5703279887079504d
parent3efd7912d9f8bedf1f46b0ebe4d80d976f62edfb
net/net: Fix incorrect condition for calling grub_net_tcp_retransmit()

The commit 848724273e4 (net/net: Avoid unnecessary calls to
grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
The call to grub_net_tcp_retransmit() should only be made when
grub_net_cards does _not_ equal NULL, meaning that there are potentially
network cards that need TCP retransmission.

Fixes: 848724273e4 (net/net: Avoid unnecessary calls to grub_net_tcp_retransmit())
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/net/net.c