]> git.ipfire.org Git - thirdparty/linux.git/commit
KVM: arm64: vgic-its: Avoid potential UAF in LPI translation cache
authorOliver Upton <oliver.upton@linux.dev>
Thu, 4 Jan 2024 18:32:32 +0000 (18:32 +0000)
committerMarc Zyngier <maz@kernel.org>
Thu, 4 Jan 2024 19:26:34 +0000 (19:26 +0000)
commitad362fe07fecf0aba839ff2cc59a3617bd42c33f
treef0fabc18b2c1ae7a9202ee2a62d317275c525ba1
parent39084ba8d0fceb477a264e2bb8dfd3553876b84c
KVM: arm64: vgic-its: Avoid potential UAF in LPI translation cache

There is a potential UAF scenario in the case of an LPI translation
cache hit racing with an operation that invalidates the cache, such
as a DISCARD ITS command. The root of the problem is that
vgic_its_check_cache() does not elevate the refcount on the vgic_irq
before dropping the lock that serializes refcount changes.

Have vgic_its_check_cache() raise the refcount on the returned vgic_irq
and add the corresponding decrement after queueing the interrupt.

Cc: stable@vger.kernel.org
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20240104183233.3560639-1-oliver.upton@linux.dev
arch/arm64/kvm/vgic/vgic-its.c