]> git.ipfire.org Git - people/arne_f/kernel.git/commit
sched/fair: Initialize throttle_count for new task-groups lazily
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Thu, 16 Jun 2016 12:57:01 +0000 (15:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 May 2017 12:30:12 +0000 (14:30 +0200)
commitada79b5ecda79ec7b53053d9955a5ee04c8dd633
tree962f34d8309d5fc336533b27f7c18607fc2dc5ee
parentf01ae9cb0de282abfd20cd3c2e3477adbdb766ce
sched/fair: Initialize throttle_count for new task-groups lazily

commit 094f469172e00d6ab0a3130b0e01c83b3cf3a98d upstream.

Cgroup created inside throttled group must inherit current throttle_count.
Broken throttle_count allows to nominate throttled entries as a next buddy,
later this leads to null pointer dereference in pick_next_task_fair().

This patch initialize cfs_rq->throttle_count at first enqueue: laziness
allows to skip locking all rq at group creation. Lazy approach also allows
to skip full sub-tree scan at throttling hierarchy (not in this patch).

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bsegall@google.com
Link: http://lkml.kernel.org/r/146608182119.21870.8439834428248129633.stgit@buzz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Ben Pineau <benjamin.pineau@mirakl.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/sched/fair.c
kernel/sched/sched.h