]> git.ipfire.org Git - thirdparty/qemu.git/commit
qga/commands-posix: Fix bug in guest-fstrim
authorJustin Ossevoort <justin@quarantainenet.nl>
Mon, 11 May 2015 06:58:44 +0000 (08:58 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 29 Jul 2015 23:24:00 +0000 (18:24 -0500)
commitae0fa48f514db72c4ce37eec666ea68c63299a8c
tree0760e5701628f52ebbd127172d6db343efec28b4
parentbb3a1da4d4a77bf133461ca23cdd52d65fe8fead
qga/commands-posix: Fix bug in guest-fstrim

The FITRIM ioctl updates the fstrim_range structure it receives. This
way the caller can determine how many bytes were trimmed. The
guest-fstrim logic reuses the same fstrim_range for each filesystem,
effectively limiting each filesystem to trim at most as much as the
previous was able to trim.

If a previous filesystem would have trimmed 0 bytes, than the next
filesystem would report an error 'Invalid argument' because a FITRIM
request with length 0 is not valid.

This change resets the fstrim_range structure for each filesystem.

Signed-off-by: Justin Ossevoort <justin@quarantainenet.nl>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
(cherry picked from commit 73a652a1b08445e8d91e50cdbb2da50e571c61b3)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/commands-posix.c