]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mwifiex: prevent an array overflow
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Apr 2019 08:44:23 +0000 (11:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:43:23 +0000 (06:43 -0700)
commitae745a8b592d44c31b9b657051863e15a61a6344
tree1877695cb9263e9f0589c0c394145a999e767c5e
parent50c312ad3ebd0c96e947b726dc06b9642a63aad1
mwifiex: prevent an array overflow

[ Upstream commit b4c35c17227fe437ded17ce683a6927845f8c4a4 ]

The "rate_index" is only used as an index into the phist_data->rx_rate[]
array in the mwifiex_hist_data_set() function.  That array has
MWIFIEX_MAX_AC_RX_RATES (74) elements and it's used to generate some
debugfs information.  The "rate_index" variable comes from the network
skb->data[] and it is a u8 so it's in the 0-255 range.  We need to cap
it to prevent an array overflow.

Fixes: cbf6e05527a7 ("mwifiex: add rx histogram statistics support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/mwifiex/cfp.c