]> git.ipfire.org Git - thirdparty/qemu.git/commit
COLO-compare: Fix incorrect `if` logic
authorFan Yang <Fan_Yang@sjtu.edu.cn>
Tue, 24 Sep 2019 14:08:29 +0000 (22:08 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 4 Nov 2019 14:25:01 +0000 (08:25 -0600)
commitaea18ef938c115f02e269ab6c8bc83dc5126db19
tree4be8b81241887bf3b7893ae71625d480d7dd237a
parent4887acf574a573137660aa98d9d422ece0a41a5a
COLO-compare: Fix incorrect `if` logic

'colo_mark_tcp_pkt' should return 'true' when packets are the same, and
'false' otherwise.  However, it returns 'true' when
'colo_compare_packet_payload' returns non-zero while
'colo_compare_packet_payload' is just a 'memcmp'.  The result is that
COLO-compare reports inconsistent TCP packets when they are actually
the same.

Fixes: f449c9e549c ("colo: compare the packet based on the tcp sequence number")
Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Fan Yang <Fan_Yang@sjtu.edu.cn>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit 1e907a32b77e5d418538453df5945242e43224fa)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
net/colo-compare.c