]> git.ipfire.org Git - people/arne_f/kernel.git/commit
random: Add comment to random_initialize()
authorTony Luck <tony.luck@intel.com>
Mon, 23 Jul 2012 16:47:57 +0000 (09:47 -0700)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Fri, 17 Aug 2012 19:36:09 +0000 (15:36 -0400)
commitaed22e34348fd7914fafcd9d35c58de486ce7a0a
tree01143da1bf051639d42133bf5f5e3f8dc0fef212
parentb1e34220df49a66f2bdd52eb2326252e819eefe1
random: Add comment to random_initialize()

commit cbc96b7594b5691d61eba2db8b2ea723645be9ca upstream.

Many platforms have per-machine instance data (serial numbers,
asset tags, etc.) squirreled away in areas that are accessed
during early system bringup. Mixing this data into the random
pools has a very high value in providing better random data,
so we should allow (and even encourage) architecture code to
call add_device_randomness() from the setup_arch() paths.

However, this limits our options for internal structure of
the random driver since random_initialize() is not called
until long after setup_arch().

Add a big fat comment to rand_initialize() spelling out
this requirement.

Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/char/random.c