]> git.ipfire.org Git - thirdparty/git.git/commit
negotiator: unknown fetch.negotiationAlgorithm should error out
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Wed, 1 Aug 2018 15:18:34 +0000 (15:18 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 1 Aug 2018 18:07:47 +0000 (11:07 -0700)
commitaf3a67de014a145216ef06b588733cd0db002990
tree615ad6e9f1ae22040f57b2e7fba6f0489dad465b
parent35e22d54ed3ee237a88c8e7ddeae7f1305011830
negotiator: unknown fetch.negotiationAlgorithm should error out

Change the handling of fetch.negotiationAlgorithm=<str> to error out
on unknown strings, i.e. everything except "default" or "skipping".

This changes the behavior added in 42cc7485a2 ("negotiator/skipping:
skip commits during fetch", 2018-07-16) which would ignore all unknown
values and silently fall back to the "default" value.

For a feature like this it's much better to produce an error than
proceed. We don't want users to debug some amazingly slow fetch that
should benefit from "skipping", only to find that they'd forgotten to
deploy the new git version on that particular machine.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/config.txt
fetch-negotiator.c
t/t5552-skipping-fetch-negotiator.sh