]> git.ipfire.org Git - thirdparty/systemd.git/commit
cryptsetup-generator: Don't mistake NULL input as OOM (#7688)
authorJan Alexander Steffens <jan.steffens@gmail.com>
Mon, 18 Dec 2017 13:47:18 +0000 (14:47 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 18 Dec 2017 13:47:18 +0000 (14:47 +0100)
commitaff0b1fa7bf2ca60fd5ffdf7ea25184d576cf61d
tree69936d9de7a0145cc58f59a2c259c82648b8248f
parent4dfdca3148ac9ecba9ea1ff16b75d514dc00e2bc
cryptsetup-generator: Don't mistake NULL input as OOM (#7688)

Since systemd v236, several Arch users complained that
systemd-cryptsetup-generator exits with an OOM error and that it
prevents the boot from continuing.

Investigating the diff of cryptsetup-generator between v235 and v236 I
noticed that create_disk allowed for the `password` and `filtered`
variables to be NULL (they're handled with `strempty()`) but not their
`*_escaped` versions, and returned OOM errors in those cases.

Fix this by checking that the input string is non-NULL before deciding
that `specifier_escape` had an OOM error.

I could not test this fix myself, but some users have reported success.

Downstream bug: https://bugs.archlinux.org/task/56733
src/cryptsetup/cryptsetup-generator.c