]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ACPI: APEI: EINJ: Fix resource leak by remove callback in .exit.text
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Thu, 14 Aug 2025 05:11:57 +0000 (07:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:34:32 +0000 (16:34 +0200)
commitb02eec41c9bb61c900e6afa479b96a4cd468f405
tree75f8b90c3986ae302cf9786bf3b0faf676125e0c
parent908094681f645d3a78e18ef90561a97029e2df7b
ACPI: APEI: EINJ: Fix resource leak by remove callback in .exit.text

commit b21d1fbb97c814c76ffa392cd603f8cd3ecc0355 upstream.

The .remove() callback is also used during error handling in
faux_probe(). As einj_remove() was marked with __exit it's not linked
into the kernel if the driver is built-in, potentially resulting in
resource leaks.

Also remove the comment justifying the __exit annotation which doesn't
apply any more since the driver was converted to the faux device
interface.

Fixes: 6cb9441bfe8d ("ACPI: APEI: EINJ: Transition to the faux device interface")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Cc: 6.16+ <stable@vger.kernel.org> # 6.16+
Link: https://patch.msgid.link/20250814051157.35867-2-u.kleine-koenig@baylibre.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/acpi/apei/einj-core.c