]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix another longstanding problem in copy_relation_data: it was blithely
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 29 Jul 2010 19:23:37 +0000 (19:23 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 29 Jul 2010 19:23:37 +0000 (19:23 +0000)
commitb08fd11508a2b36e64f456d8e0345f1c66dae333
tree05f32934ec1106fbba8c6d4b1761b253d29cbb0d
parent2d8346182f5cbf743aa2a807893291d74321f8c0
Fix another longstanding problem in copy_relation_data: it was blithely
assuming that a local char[] array would be aligned on at least a word
boundary.  There are architectures on which that is pretty much guaranteed to
NOT be the case ... and those arches also don't like non-aligned memory
accesses, meaning that log_newpage() would crash if it ever got invoked.
Even on Intel-ish machines there's a potential for a large performance penalty
from doing I/O to an inadequately aligned buffer.  So palloc it instead.

Backpatch to 8.0 --- 7.4 doesn't have this code.
src/backend/commands/tablecmds.c